於 四,2012-07-05 於 01:30 +0200,Marek Vasut 提到: > The patch 6ae3a0876185: "ACER: Add support for accelerometer sensor" > from Jun 1, 2012, leads to the following Smatch warning: > drivers/platform/x86/acer-wmi.c:1886 acer_wmi_accel_destroy() > error: don't call input_free_device() after input_unregister_device() > > drivers/platform/x86/acer-wmi.c > 1883 static void acer_wmi_accel_destroy(void) > 1884 { > 1885 input_unregister_device(acer_wmi_accel_dev); > 1886 input_free_device(acer_wmi_accel_dev); > 1887 } > > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > Cc: Matthew Garrett <mjg59@xxxxxxxxxxxxx> > Cc: Fengguang Wu <wfg@xxxxxxxxxxxxxxx> > Cc: joeyli <jlee@xxxxxxxx> > Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Acked-by: joeyli <jlee@xxxxxxxx> Thanks Joey Lee > --- > drivers/platform/x86/acer-wmi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c > index ae969fd..f4ed2af 100644 > --- a/drivers/platform/x86/acer-wmi.c > +++ b/drivers/platform/x86/acer-wmi.c > @@ -1883,7 +1883,6 @@ err_free_dev: > static void acer_wmi_accel_destroy(void) > { > input_unregister_device(acer_wmi_accel_dev); > - input_free_device(acer_wmi_accel_dev); > } > > static int __init acer_wmi_input_setup(void) -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html