Re: [PATCH 2/2] ACER: Add support for ambient light sensor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 4, 2012 at 7:14 PM, Marek Vasut <marex@xxxxxxx> wrote:
> Dear Corentin Chary,
>
>> On Fri, Jun 1, 2012 at 7:11 PM, Marek Vasut <marex@xxxxxxx> wrote:
>> > This is the ambient light sensor found on Iconia W500.
>> >
>> > Signed-off-by: Marek Vasut <marex@xxxxxxx>
>> > Cc: joeyli <jlee@xxxxxxxx>
>> > ---
>
> [...]
>
>> > +static int __init acer_wmi_alsd_setup(void)
>> > +{
>> > +       int err;
>> > +
>> > +       err = acer_wmi_get_handle("ALSD", "ACPI0008", &alsd_handle);
>> > +       if (err)
>> > +               return err;
>>
>> NACK !
>
> What are you trying to achieve with such attitude? Are you trying to show off
> how much you can scream at someone new? I'd tell you some really harsh words and
> would turn my back on all this linux stuff if I wasn't used to people in kernel
> mailing lists having quite weird manners sometimes.

Sorry, that really wasn't what I meant. ACK / NACK are traditionnaly
written like this arround here, but the "!" was probably too much.

>
>> This is a generic device, and should be handled by ACPI core
>> (Samsung laptop have this too). See "ACPI ALS" on linux-acpi.
>
> Saying this would be enough. Lee explained to me what this ACPI0008 means, I'm
> quite new to the ACPI land so pardon my ignorance here. But it then boils down
> to Lee's question, why wasn't the patch for ACPI ALS that was already proposed
> accepted? And what can be done to get it in?

Yep, I've seen Lee's message latter. Regarding ACPI ALS status, it was
forgotten for a long time, and recently Zhang Rui told that he will
take another look at it, but nothing sure. If you want to know more
about the status, you can do a quick search on gmane using "ACPI ALS"
query on linux.acpi


-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux