於 二，2011-08-09 於 14:33 +0800，AceLan Kao 提到：
> Dear Joey,
>
> The current project we have right now have to follow the Acer WMI to
> handle the key events, that means no EC key event.
> And we have 3 keys that are not working now, they are touchpad toggle,
> brightness up, and brightness down.
> The touchpad toggle function is a Hotkey Break Event(function number
> 0x2), and brightness key events are Brightness Change Event(function
> number 0x4). But now acer-wmi driver only handles General Hotkey
> Event(function number 0x1).
>
Yes, current acer-wmi only capture the event function number 0x1, you
can add those new function to acer_wmi_notify().
> I just implemented those 3 key events, so I think maybe we don't have
> to create a new acer-wmi driver.
Great! Welcome for you patches, I will also test it.
> I'm longing for your work to clear up the acer-wmi driver, so that I
> can add the new machine id and send you the patch.
> Thanks.
>
> BTW, I'm available to help if you are too busy to do that.
>
> Best regards,
> AceLan Kao.
>
I am doing the clear up, now, will send out patch (I hope today).
Thank's
Joey Lee
> 2011/8/9 joeyli <jlee@xxxxxxxx>:
> > 於 二，2011-08-09 於 10:05 +0800，AceLan Kao 提到：
> >> Dear Joey,
> >>
> >> Is there any progress of the acer-wmi patch?
> >>
> >
> > Sorry for I am busy from last 2 weeks until now.
> >
> >> I read the Acer WMI/SMBIOS Spec. and think we might need to create a
> >> new acer-wmi driver for the new machines and leave the original
> >> acer-wmi driver for the old ones.
> >> The GUID is changed and there are more functions be added in the spec.
> >> that the acer-wmi driver is hard to handle now.
> >> And I'm not sure if I can implement a open source wmi driver from the spec.
> >> Please input more idea about this, thanks.
> >>
> >> Best regards,
> >> AceLan Kao.
> >>
> >
> > I don't think we need a new acer-wmi driver to handle new machine,
> > because acer-wmi driver already support the following WMI methods:
> >
> > #define WMID_GUID3 "61EF69EA-865C-4BC3-A502-A0DEBA0CB531"
> > #define ACERWMID_EVENT_GUID "676AA15E-6A47-4D9F-A2CC-1E6D18D14026"
> >
> > I will find a bit time at this week to clear up acer-wmi driver.
> >
> > Did you see any function key or new function didn't handle by current
> > acer-wmi driver?
> >
> >
> > Thank's
> > Joey Lee
> >
> >> 2011/7/19 Joey Lee <jlee@xxxxxxxxxx>:
> >> > Cc. to platform driver mail
> >> >
> >> > Hi AceLan,
> >> >
> >> > In old acer machine supports both old WMI_GUID1 and new WMI_WMID3, but
> >> > more and more machines removed old WMI_GUID1 method and just support new
> >> > one.
> >> >
> >> > I will spend a bit time to clear up acer-wmi driver, add support to
> >> > those new machines.
> >> > I will send out patches for review.
> >> >
> >> >
> >> >
> >> > Thank's a lot!
> >> > Joey Lee
> >> >
> >> >
> >> > -------- 轉遞的郵件 --------
> >> >> 自: AceLan Kao <acelan.kao@xxxxxxxxxxxxx>
> >> >> 至: Joey Lee <jlee@xxxxxxxxxx>
> >> >> 主旨: Re: A problem about acer-wmi
> >> >> 日期: Tue, 19 Jul 2011 11:37:28 +0800
> >> >>
> >> >> Dear Joey,
> >> >>
> >> >> Thanks for your quick response.
> >> >> Here are the logs and it's good to discuss this issue on platform driver list.
> >> >> Thanks.
> >> >>
> >> >> Best regards,
> >> >> AceLan Kao.
> >> >>
> >> >> 2011/7/19 Joey Lee <jlee@xxxxxxxxxx>:
> >> >> > 於 二，2011-07-19 於 02:57 +0000，joeyli(Joey Lee) 提到：
> >> >> >> Hi Kao,
> >> >> >>
> >> >> >> 於 二，2011-07-19 於 09:43 +0800，AceLan Kao 提到：
> >> >> >> > Dear Joey,
> >> >> >> >
> >> >> >> > We have a new machine the model is Acer Aspire 4739Z
> >> >> >> > I tried to add it's model in acer_quirks struct, but in
> >> >> >> > acer_wmi_init(), it can't find it's interface.
> >> >> >> > {
> >> >> >> > .callback = dmi_matched,
> >> >> >> > .ident = "Acer Aspire 4739Z",
> >> >> >> > .matches = {
> >> >> >> > DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> >> >> >> > DMI_MATCH(DMI_PRODUCT_NAME, "AS4739Z"),
> >> >> >> > },
> >> >> >> > .driver_data = &quirk_acer_travelmate_2490,
> >> >> >> > },
> >> >> >> >
> >> >> >> > wmi_has_guid(AMW0_GUID1), wmi_has_guid(WMID_GUID1), and
> >> >> >> > wmi_has_guid(WMID_GUID2) all return 0.
> >> >> >> > And, wmi_has_guid(WMID_GUID3) and wmi_has_guid(ACERWMID_EVENT_GUID) return 1.
> >> >> >> >
> >> >> >> > I don't understand the logic of those wmi_has_guid(), so I don't know
> >> >> >> > how to modify them, I just assigned the interface as
> >> >> >> > interface = &wmid_interface;
> >> >> >> > and that would make us capture the KEY_F22(Touch Pad On/Off) event and
> >> >> >> > get the OSD appeared.
> >> >> >> >
> >> >> >> > Please direct me how to add this h/w correctly into acer_wmi.c and
> >> >> >> > please let me know if I should provide any info you need.
> >> >> >> > Thanks.
> >> >> >> >
> >> >> >> > Best regards,
> >> >> >> > AceLan Kao.
> >> >> >> >
> >> >> >>
> >> >> >> Thank's for you pay attention to acer-wmi driver. Please attached the
> >> >> >> dmidecode log and acpidump on this mail to me.
> >> >> >> Then, I can trace the DSDT to find out good way.
> >> >> >>
> >> >> >
> >> >> > Forgot tell how to capture the log and DSDT:
> >> >> > + dmidecode > dmidecode.log
> >> >> > + acpidump > acpidump.dat
> >> >> >
> >> >> >
> >> >> > Thank's a lot!
> >> >> > Joey Lee
> >> >> >
> >> >> >> And,
> >> >> >> Do you mind if I forward this mail to platform driver group on kernel
> >> >> >> upstream?
> >> >> >> Then we can discuss on upstream, maybe have more experts can provide
> >> >> >> commants to us.
> >> >> >>
> >> >> >>
> >> >> >> Thank's a lot!
> >> >> >> Joey Lee
> >> >> >
> >> >> >
> >> >> >
> >> >>
> >> >>
> >> >>
> >> >
> >> >
> >> >
> >>
> >>
> >>
> >
> >
> >
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
