Re: [PATCH 2/4] acer-wmi: check the existence of internal 3G device when set capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Carlos, 

æ äï2011-05-23 æ 07:41 +0100ïCarlos Corbacho æåï
> On Monday 23 May 2011 07:39:36 Joey Lee wrote:
> > > I'm not sure you can drop sysfs files like that, as it will break the
> > > ABI.
> >>
> > > Could you document acer-wmi in
> > > Documentation/ABI/testing/sysfs-platform-acer-wmi.txt ?
> > > This allows to check when a sysfs file was added, who use it, etc...
> 
> I don't agree, the 3G sysfs interface should just be dropped as it's the only 
> remaining sysfs stuff for this driver - it's not worth documenting as it's 
> already exposed as an rfkill device, and we've already dropped all the 
> remaining sysfs interfaces a long time ago without going through any of this.
> 

After removed threeg sysfs file, there still have the latest one sysfs
file the name is "interface". It provide a interface to know which WMI
interface was used currently.

Should we also direct drop it from acer-wmi or move to debugfs?


Thank's a lot!
Joey Lee



--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux