On Mon, May 23, 2011 at 8:41 AM, Carlos Corbacho <carlos@xxxxxxxxxxxxxxxxxxx> wrote: > On Monday 23 May 2011 07:39:36 Joey Lee wrote: >> > I'm not sure you can drop sysfs files like that, as it will break the >> > ABI. >>> >> > Could you document acer-wmi in >> > Documentation/ABI/testing/sysfs-platform-acer-wmi.txt ? >> > This allows to check when a sysfs file was added, who use it, etc... > > I don't agree, the 3G sysfs interface should just be dropped as it's the only > remaining sysfs stuff for this driver - it's not worth documenting as it's > already exposed as an rfkill device, and we've already dropped all the > remaining sysfs interfaces a long time ago without going through any of this. > > Besides, anybody who used it (and I never could find any 3G users of Acer > laptops on Linux) was never guaranteed it wouldn't break horribly anyway as we > couldn't properly autodetect 3G in the past or knew much about it other than > Acer's WMI API suggested it existed. I asked for documentation because I didn't check if there were other sysfs files remaining, if it's the last, we don't really care. I did a quick search, and you're right, this file doesn't seems to have a lot of user, but it would still break the ABI without any notice. I would be more confortable with one or two cycle with this feature marked as deprecated and scheduled for removal. -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
