On Thu, May 12, 2011 at 10:24:10AM -0400, Andrew Lutomirski wrote: > On Thu, May 12, 2011 at 9:48 AM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > > It looks like SAUM was introduced with the *61 machines, and it's > > identical from then on. > > I wonder the machines with SAUM are the same as the machines on which > pressing mute generates an i8042 keystroke instead of an HKEY. If so, > it looks like there's some code (or at least comments) in > thinkpad_acpi that mention doing the right thing when the HKEY mute > event in generated (e.g. the driver won't send KEY_MUTE to the input > layer), so something like my patch along with removing the _OSI(Linux) > hack for the newer models might make everything work right. I think so. The machines we have in the OSI blacklist all appear to have the SAUM method, so I think we can take your patch and drop the blacklist. Good work! > Still, someone who has an older laptop should test it, because all I > can do is pretend I carefully inspected all the possible code paths. I can't see any way this would cause problems, except in the case where the method exists but doesn't do anything. I'd be surprised if that's a real problem. > (Even if it works, don't apply this patch for 2.6.40 as it stands > because the ALSA change notification on KEY_MUTE is crap and should at > least ignore key release events.) Are you working with the ALSA people on that? -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
