Re: [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 12, 2011 at 9:48 AM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
> On Mon, May 09, 2011 at 06:18:46PM -0400, Andy Lutomirski wrote:
>
>> Henrique, do you know of anywhere to find AML dumps from different models?
>> It would be nice to see what SAUM looks like.
>
> It looks like SAUM was introduced with the *61 machines, and it's
> identical from then on.

I wonder the machines with SAUM are the same as the machines on which
pressing mute generates an i8042 keystroke instead of an HKEY.  If so,
it looks like there's some code (or at least comments) in
thinkpad_acpi that mention doing the right thing when the HKEY mute
event in generated (e.g. the driver won't send KEY_MUTE to the input
layer), so something like my patch along with removing the _OSI(Linux)
hack for the newer models might make everything work right.

Still, someone who has an older laptop should test it, because all I
can do is pretend I carefully inspected all the possible code paths.

(Even if it works, don't apply this patch for 2.6.40 as it stands
because the ALSA change notification on KEY_MUTE is crap and should at
least ignore key release events.)

--Andy

>
> --
> Matthew Garrett | mjg59@xxxxxxxxxxxxx
>
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux