Hi Carios, æ äï2011-03-02 æ 21:09 +0000ïCarlos Corbacho æåï > On Wednesday 02 Mar 2011 08:53:55 Joey Lee wrote: > > æ äï2011-01-03 æ 20:49 +0000ïMatthew Garrett æåï > > > > > It looks like this GUID is present in a surprisingly wide range of > > > devices (eg, http://pastebin.com/8BY0Dg64 from a Vaio...), which means > > > that it's probably not a safe assumption that reading from the EC will > > > give us reasonable results. Do the Acer drivers definitely do that, > > > rather than there being some SMI that returns the data? > > > > The AMW0 in acer-wmi not just used by acer machines: > > > > #define AMW0_GUID1 "67C3371D-95A3-4C37-BB61-DD47B491DAAB" > > > > It was also included in Lenovo Ideapad S12 and Vaio machines' DSDT. For > > Lenovo Ideapad, that will be better handle by ideapad-laptop driver. > The original issue was reported by Ville-Pekka Vaino, acer-wmi driver auto-probe on Ideapad S12 machine by detection AWM0. But, acer-wmi adds a soft blocked wifi killswitch, which can't be unblocked with rfkill, it causes problems with NetworkManager wireless network can't be enabled at all. > They might not be - Matthew's original question still stands. The old AMW0 was > just a funny wrapper for direct BIOS calls - maybe we just need a different > call here? > Understood your point. In acer-wmi driver, by the default ACER_CAP_WIRELESS = 0, looks this case not work for Ideapad S12. If we want to support S12 in acer-wmi for maintain the wlan rfkill, then we need find out the new EC pattern to read the wireless state and add it to acer-wmi. We need Vaino help to run acer_ec.pl to capture the EC register status. > What does Acer do - are they poking the EC directly, or is the call to AMW0 > just different for these machines? > You are right, AMW0 just a wrapper the detail wlan rfkill state sync by direct access EC register, we will need to know how the S12's EC registers state changed. On the other hand, Vaino said the ideapad-laptop driver works fine on his S12 machine to handle killswitches. Per Per Ike's information, ideapad-laptop driver support S12 machine by VPC2004 devices and I also simply check Ideapad S12's DSDT that was dumped by Ville-Pekka Vaino, it declare VPC2004 devices in EC block. The ideapad-laptop also maintain a wlan killswitch state by access VPC2004 devices, but this driver have no alias and doesn't auto-probe. Should we still maintain a wlan killswitch by acer-wmi when ideapad-laptop also maintain the same wlan killswitch by itself? > > Could we just direct add those model to the blacklist in acer-wmi > > driver? or we direct check dmi in acer-wmi for only support Acer > > machines that were included AMW0 in DSDT? > > Interesting. If we can't autodetect whether it's a dummy interface or not, > then, we should change acer-wmi to whitelist what it does support - Acer, > Fujistu Siemens and Medion - rather than trying to blacklist every vendor that > crops up. > > -Carlos I thought there have 2 choices: - In acer-wmi driver, maybe we can walk through acpi device to check if there have VPC2004 devices in DSDT, then we direct ignore this machine's AWM0 supported. or - We still try to support Ideapad S12 in acer-wmi, we maintain a wlan killswitch even it duplicate with ideapad-laptop's wlan killswitch. We need Vaino help to run acer_ec.pl. Do you think which one is better for this case? Thank's a lot! Joey Lee -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
