Re: acer-wmi is unnecessarily loaded on a Lenovo Ideapad S12

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vainio, 

æ äï2010-12-28 æ 19:28 +0200ïVille-Pekka Vainio æåï
> I decided to upload the files to the web instead of attaching them to
> the email since they are quite large.
> 
> ti, 2010-12-28 kello 08:36 -0700, Joey Lee kirjoitti:
> > It's not make sense acer-wmi probe on Ideapad S12 netbook, could you
> > please help to attached the following information?
> > 
> > - modinfo acer-wmi > acer-wmi.log
> 
> http://vpv.kapsi.fi/ideapad-s12/modinfo-acer-wmi.txt
> 
> > - dmesg > dmesg.log
> 
> http://vpv.kapsi.fi/ideapad-s12/dmesg-acer-wmi.txt
> 
> > - dmidecode > dmidecode.log
> 
> http://vpv.kapsi.fi/ideapad-s12/dmidecode-acer-wmi.txt
> 
> > - acpidump > acpidump.dat
> 
> http://vpv.kapsi.fi/ideapad-s12/acpidump.dat
> 

It's funny Lenovo S12's _WDG have GUID that matches with Acer AMW0.

Dump from Lenovo Ideapad S12's _WDG:

67C3371D-95A3-4C37-BB61-DD47B491DAAB:
        object_id: AB
        notify_id: 41
        reserved: 42
        instance_count: 1
        flags: 0x2 ACPI_WMI_METHOD


In acer-wmi code:

#define AMW0_GUID1              "67C3371D-95A3-4C37-BB61-DD47B491DAAB"

MODULE_ALIAS("wmi:67C3371D-95A3-4C37-BB61-DD47B491DAAB");	//match



Maybe Wistron is the ODM (or OEM) to manufacture Lenovo Ideapad S12 ?
Anyway, 
I added this Ideapad S12 to blacklist in acer-wmi driver because it must
supported by ideapad-laptop driver.

I also added Cc. to Carlos Corbacho, need his review.

Does is possible you help to test this patch?


Thank's a lot!
Joey Lee



>From 194a1b499c36db057319712220af8ec7400030d7 Mon Sep 17 00:00:00 2001
From: Lee, Chun-Yi <jlee@xxxxxxxxxx>
Date: Wed, 29 Dec 2010 00:17:23 +0800
Subject: [PATCH] Add Lenovo Ideapad S12 to acer blacklist

The Lenovo Ideapad S12's _WDG have GUID that matches with AMW0, it causes
acer-wmi driver auto-probe when system boot but there already have
ideapad-laptop driver to support Ideapad serial.
So, add Lenovo Ideapad S12 to acer blacklist to disable it.

Signed-off-by: Lee, Chun-Yi <jlee@xxxxxxxxxx>
Cc: Carlos Corbacho <carlos@xxxxxxxxxxxxxxxxxxx>
---
 drivers/platform/x86/acer-wmi.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 28288ad..387ac7c 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -310,6 +310,17 @@ static struct dmi_system_id __devinitdata acer_blacklist[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
 		},
 	},
+	/*
+	 * The Lenovo Ideapad S12 have GUID that matches with AMW0 - disable it.
+	 * There already have ideapad-laptop driver to support Ideapad serial.
+	 */
+	{
+		.ident = "Lenovo Ideapad S12",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "20021,2959"),
+		},
+	},
 	{}
 };
 
-- 
1.6.0.2



--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux