Add Cc. David Woodhouse Hi Carlos, æ åï2010-12-30 æ 10:04 +0000ïCarlos Corbacho æåï > On Wednesday 29 December 2010 04:30:03 Joey Lee wrote: > > [..] > > > Maybe Wistron is the ODM (or OEM) to manufacture Lenovo Ideapad S12 ? > > Anyway, > > I added this Ideapad S12 to blacklist in acer-wmi driver because it must > > supported by ideapad-laptop driver. > > > > I also added Cc. to Carlos Corbacho, need his review. > > I suspect this is the same as all the Acer netbooks - they provide a dummy WMI > interface which doesn't actually do anything. It would be nicer if there were > a more generic way to do this, but this will do for now (I may try to play > around with my Aspire One and see if I can figure out some way to detect the > dummy interface, without needing to resort to DMI). > The issue reporter Vainio help to dump the acpi informatoin and put here: > - acpidump > acpidump.dat http://vpv.kapsi.fi/ideapad-s12/acpidump.dat There have AMW0 declare in DSDT: Device (AMW0) { Name (_HID, "*pnp0c14") Name (_UID, 0x00) Name (WLMP, 0x00) Name (WMID, 0x00) Name (B0ED, Buffer (0x04) Per Vainio's report, the wlan rfkill cann't set to un-block when he used acer-wmi driver, but ideapad-laptop driver handle the killswitches better. Sorry, I have no ideapad S12 machine for double check. Need David Woodhouse or Ville-Pekka Vainio's confirm the ideapad-laptop driver supports Ideapad S12 netbook. I just simply checked the ideapad-laptop source code, it handle the killswitch state by access EC address, if it works, then acer-wmi don't need probe and touch the same function. So, I thought still need add S12's dmi information to blacklist in acer-wmi to avoid conflict. > [..] > > > From: Lee, Chun-Yi <jlee@xxxxxxxxxx> > > Date: Wed, 29 Dec 2010 00:17:23 +0800 > > Subject: [PATCH] Add Lenovo Ideapad S12 to acer blacklist > > > > The Lenovo Ideapad S12's _WDG have GUID that matches with AMW0, it causes > > acer-wmi driver auto-probe when system boot but there already have > > ideapad-laptop driver to support Ideapad serial. > > So, add Lenovo Ideapad S12 to acer blacklist to disable it. > > > > Signed-off-by: Lee, Chun-Yi <jlee@xxxxxxxxxx> > > Cc: Carlos Corbacho <carlos@xxxxxxxxxxxxxxxxxxx> > > Acked-by: Carlos Corbacho <carlos@xxxxxxxxxxxxxxxxxxx> Thank's a lot for your acked. Joey Lee > > --- > > drivers/platform/x86/acer-wmi.c | 11 +++++++++++ > > 1 files changed, 11 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/platform/x86/acer-wmi.c > > b/drivers/platform/x86/acer-wmi.c index 28288ad..387ac7c 100644 > > --- a/drivers/platform/x86/acer-wmi.c > > +++ b/drivers/platform/x86/acer-wmi.c > > @@ -310,6 +310,17 @@ static struct dmi_system_id __devinitdata > > acer_blacklist[] = { DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"), > > }, > > }, > > + /* > > + * The Lenovo Ideapad S12 have GUID that matches with AMW0 - disable it. > > + * There already have ideapad-laptop driver to support Ideapad serial. > > + */ > > + { > > + .ident = "Lenovo Ideapad S12", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "20021,2959"), > > + }, > > + }, > > {} > > }; -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
