On Thu, 30 Dec 2010 21:41:17 +0800 Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > On Thu, Dec 30, 2010 at 05:32:54PM +0800, Feng Tang wrote: > > Latest kernel has many changes in IRQ subsystem and its interfaces, > > like adding "irq_eoi" for struct irq_chip, this patch will make it > > support both the new and old interface. > > There's no point in having compatibility stubs in the mainline > kernel. Just fix the driver up to match the new behaviour. > Thanks for the comments, here is the revised one ----- >From 834453fe4cb94cfcda4487ef68967037f2b5d2f2 Mon Sep 17 00:00:00 2001 From: Feng Tang <feng.tang@xxxxxxxxx> Date: Mon, 29 Nov 2010 13:39:40 +0800 Subject: [PATCH] intel_pmic_gpio: modify EOI handling following change of kernel irq subsystem Latest kernel has many changes in IRQ subsystem and its interfaces, like adding "irq_eoi" for struct irq_chip, this patch will make it support both the new and old interface. Cc: Alek Du <alek.du@xxxxxxxxx> Signed-off-by: Feng Tang <feng.tang@xxxxxxxxx> --- drivers/platform/x86/intel_pmic_gpio.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/platform/x86/intel_pmic_gpio.c b/drivers/platform/x86/intel_pmic_gpio.c index e61db9d..930e627 100644 --- a/drivers/platform/x86/intel_pmic_gpio.c +++ b/drivers/platform/x86/intel_pmic_gpio.c @@ -244,7 +244,11 @@ static void pmic_irq_handler(unsigned irq, struct irq_desc *desc) generic_handle_irq(pg->irq_base + gpio); } } - desc->chip->eoi(irq); + + if (desc->chip->irq_eoi) + desc->chip->irq_eoi(irq_get_irq_data(irq)); + else + dev_warn(pg->chip.dev, "missing EOI handler for irq %d\n", irq); } static int __devinit platform_pmic_gpio_probe(struct platform_device *pdev) -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
