Re: [PATCH v2 2/2] eeepc-wmi: Add cpufv sysfs interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 21, 2010 at 3:06 PM, Chris Bagwell <chris@xxxxxxxxxxxxxx> wrote:
> On Thu, Oct 21, 2010 at 1:45 AM, Corentin Chary
> <corentin.chary@xxxxxxxxx> wrote:
>> On Tue, Oct 12, 2010 at 1:47 AM, Â<chris@xxxxxxxxxxxxxx> wrote:
>>> From: Chris Bagwell <chris@xxxxxxxxxxxxxx>
>>>
>>> eeepc-laptop provides a sysfs interface to read and control what it
>>> calls cpufv. ÂWhen WMI is enabled, the ACPI interface changes slightly
>>> and becames a write-only control with 3 valid values.
>>>
>>> Expose cpufv again to allow for user space utils that can extended battery
>>> life noticably and come a little closer to parity with eeepc-laptop.
>>>
>>> Write-only is OK for most user space apps because read status was
>>> mostly used to prevent unneeded mode changes. ÂSince this same check
>>> to ignore changes to same mode also exists in the DSDT then it was
>>> wasted ACPI call.
>>>
>>> acpi_osi="!Windows 2009" can be used for get back eeepc-laptop's
>>> read support of cpufv for debugging things such as behaviour
>>> during resume.
>>>
>>> This patch was tested with EEE PC 1005PE by monitoring powertop output while
>>> writing values of "0", "1", and "2" and by reviewing the decompiled DSDT of
>>> an 1201NL and comparing it to 1005PE's DSDT.
>>>
>>> Signed-off-by: Chris Bagwell <chris@xxxxxxxxxxxxxx>
>>> ---
>
> [ ... ]
>
>>
>> Seems ok.
>> Matthew, could you add that one for inclusion in 2.6.37 ?
>>
>> Chris, could you document cpufv in
>> Documentation/ABI/testing/sysfs-platform-eeepc-wmi (see eeepc-laptop
>> example) ?
>> I don't think the lacking documentation should delay this patch because:
>> - most of platform-x86 are not documented at all
>> - the merge window is open, and we should'nt miss that.
>>
>> Thanks,
>>
>
> Sure thing. ÂAre you OK as the contact for this interface? ÂI assume
> the intent is not for author of patches.

I'm not the original author of the driver, and I'm not really the
"official" maintainer.

Yong will maintain this driver on the long term ?
If yes, please send a patch for MAINTAINER, and Chris will use your
name in the Doc file
If not, I shall declare myself maintainer for this driver, and Chris
will use mine as ABI contact

Thanks,
-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux