On Thu, Oct 21, 2010 at 1:45 AM, Corentin Chary <corentin.chary@xxxxxxxxx> wrote: > On Tue, Oct 12, 2010 at 1:47 AM, <chris@xxxxxxxxxxxxxx> wrote: >> From: Chris Bagwell <chris@xxxxxxxxxxxxxx> >> >> eeepc-laptop provides a sysfs interface to read and control what it >> calls cpufv. When WMI is enabled, the ACPI interface changes slightly >> and becames a write-only control with 3 valid values. >> >> Expose cpufv again to allow for user space utils that can extended battery >> life noticably and come a little closer to parity with eeepc-laptop. >> >> Write-only is OK for most user space apps because read status was >> mostly used to prevent unneeded mode changes. Since this same check >> to ignore changes to same mode also exists in the DSDT then it was >> wasted ACPI call. >> >> acpi_osi="!Windows 2009" can be used for get back eeepc-laptop's >> read support of cpufv for debugging things such as behaviour >> during resume. >> >> This patch was tested with EEE PC 1005PE by monitoring powertop output while >> writing values of "0", "1", and "2" and by reviewing the decompiled DSDT of >> an 1201NL and comparing it to 1005PE's DSDT. >> >> Signed-off-by: Chris Bagwell <chris@xxxxxxxxxxxxxx> >> --- [ ... ] > > Seems ok. > Matthew, could you add that one for inclusion in 2.6.37 ? > > Chris, could you document cpufv in > Documentation/ABI/testing/sysfs-platform-eeepc-wmi (see eeepc-laptop > example) ? > I don't think the lacking documentation should delay this patch because: > - most of platform-x86 are not documented at all > - the merge window is open, and we should'nt miss that. > > Thanks, > Sure thing. Are you OK as the contact for this interface? I assume the intent is not for author of patches. Chris -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
