On Tue, Jun 01, 2010 at 01:35:13PM +0100, Alan Cox wrote: > > > + * If the PMIC hasn't been discovered or one is not found > > > then > > > + * the calls will error for us. > > > > Can't you do this at probe time? > > We have to check for errors anyway. We could also check at probe time > but that would add ordering issues or mean we needed the scu_ipc driver > to create the platform device for the vibrator - which given it's not > current discoverable is a bit ugly. The ipc driver is presumably intended to probe first (and module dependencies will ensure that in the modular case). Once that probe has completed, isn't it expected that scu_ipc_ioread will error if there's no device? -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
