On Tue, Jun 01, 2010 at 12:56:46PM +0100, Alan Cox wrote:
> From: Kalhan Trisal <kalhan.trisal@xxxxxxxxx>
>
> This patch provides support for the MID vibrator can be switched
> on/off using sysfs interfaces.
Looking through the kernel, it seems that we've got there main
approaches to vibrator control - sysfs with a "speed" attribute, an
input device using the force feedback ioctls or something that's plumbed
through the sound codec. While the absence of any consistency here is
obviously a problem, I'd prefer not to add a fourth - can you at least
make the sysfs attribute "speed" (with it accepting only 0 and 1 if you
don't have any way to control the hardware beyond on and off) so it's
compatible with one of the existing implementations?
> +/*
> + * If the PMIC hasn't been discovered or one is not found then
> + * the calls will error for us.
Can't you do this at probe time?
> + if (intel_scu_ipc_iowrite8(0x49, 0xAD))
> + return -EINVAL;
> + } else {
> + if (intel_scu_ipc_iowrite8(0x49, 0x14))
> + return -EINVAL;
Is there any significance to 0xAD and 0x14? Is this register specific to
the vibrator?
Otherwise, looks good.
--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
