Re: intel_scu_ipc: Fix to overcome late initialization of scu ipc driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 30, 2010 at 11:10:03PM +0530, Ds, Sreedhara wrote:
> -static void __exit intel_scu_ipc_exit(void)
> -{
> -	pci_unregister_driver(&ipc_driver);
> -}
> -
>  MODULE_AUTHOR("Sreedhara DS <sreedhara.ds@xxxxxxxxx>");
>  MODULE_DESCRIPTION("Intel SCU IPC driver");
>  MODULE_LICENSE("GPL");
>  
> -module_init(intel_scu_ipc_init);
> -module_exit(intel_scu_ipc_exit);
> +fs_initcall(intel_scu_ipc_init);

This is wrong. If it can't be a module then delete all the other module 
code from the driver and change it to a bool in Kconfig. And don't use 
fs_initcall - subsys or arch would seem more reasonable, but you're not 
describing the problem terribly clearly. Which drivers are getting 
initialised before this?

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux