Alan, Your comment is valid. Please add it to the Meego working tree --Sreedhara -----Original Message----- From: Alan Cox [mailto:alan@xxxxxxxxxxxxxxx] Sent: Saturday, May 29, 2010 12:22 AM To: Ds, Sreedhara Cc: platform-driver-x86@xxxxxxxxxxxxxxx; mjg@xxxxxxxxxx; x86@xxxxxxxxxx Subject: Re: [Patch 1/4] intel scu ipc On Fri, 28 May 2010 14:09:39 +0530 "Ds, Sreedhara" <sreedhara.ds@xxxxxxxxx> wrote: > Hello, > Please review and accept the patch > > > From 443010eead6d69e3b60b460fd3f82344de95da5d Mon Sep 17 00:00:00 2001 > From: Sreedhara DS <sreedhara.ds@xxxxxxxxx> > Date: Fri, 28 May 2010 13:53:38 +0530 > Subject: [PATCH] changes to find platform type during int > modified: intel_scu_ipc.c > > > Signed-off-by: Sreedhara DS <sreedhara.ds@xxxxxxxxx> Code is fine but your subject/comments don't reflect the patch. That causes problems for the upstream merge because the upstream history needs to accurately describe it. Something like Subject: intel_scu_ipc: detect CPU type automatically Intel SCU message formats depend upon the processor type. Replace the module option with automatic detection of the processor type. ---- Code looks fine and I'll add it to the Meego working tree but with the comment I quoted if that is ok Alan -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
