On Fri, Apr 09, 2010 at 08:26:00PM +0200, Corentin Chary wrote:
> >
> > - ? ? ? err = eeepc_wmi_input_setup();
> > - ? ? ? if (err)
> > + ? ? ? eeepc_wmi = kzalloc(sizeof(struct eeepc_wmi), GFP_KERNEL);
> > + ? ? ? if (!eeepc_wmi) {
> > + ? ? ? ? ? ? ? pr_warning("EEEPC WMI: Unable to allocate eeepc_wmi device\n");
>
> Is this message really needed ? Anyway we now this will never happen,
> and modprobe will probably print the same thing.
OK, will remove this one.
> In fact, another noisy message could also be removed:
> pr_warning("EEEPC WMI: No known WMI GUID found\n");
Looks like most other WMI drivers all have this warning message. I'd
rather keep this one to be consistent. Is that OK?
> And speaking of messages, you cand use the pr_fmt macro (see
> eeepc-laptop for and example)
> instead of adding "EEEPC WMI:" as a prefix for all pr_ calls.
>
pr_fmt is really helpful.
Thanks
-Yong
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
