On Fri, Apr 09, 2010 at 08:26:00PM +0200, Corentin Chary wrote: > Disclaimer: most of my comments are mostly small styles issue, and you > can probably > ignore them. But I'd like eeepc-wmi style to match asus-laptop and > eeepc-laptop, this way > it will be easier to identify common code pattern. > > In fact while reviewing this patch, comparing eeepc_wmi_input_exit, > eeepc_input_exit and asus_input_exit > I found that kfree(eeepc->keymap); should not be here and sparse_keymap is not > freed (will add a patch for that soon). > > If you don't [want /have the time] to do it, I'll will submit patchs > for that later, but it's better if it's done early. > OK, now I know what the style issues mean. I will copy and paste the definitions from eeepc-laptop. -Yong -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
