Re: [PATCH v4] eeepc-wmi: new driver for WMI based hotkeys on Eee PC laptops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 22, 2010 at 08:43:41AM +0100, Corentin Chary wrote:
> On Sun, Mar 21, 2010 at 3:02 AM, Yong Wang <yong.y.wang@xxxxxxxxxxxxxxx> wrote:
> > +static const struct key_entry eeepc_wmi_keymap[] = {
> > +       /* Sleep already handled via generic ACPI code */
> > +       { KE_KEY, 0x5d, { KEY_WLAN } },
> > +       { KE_KEY, 0x32, { KEY_MUTE } },
> > +       { KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
> > +       { KE_KEY, 0x30, { KEY_VOLUMEUP } },
> > +       { KE_IGNORE, NOTIFY_BRNDOWN_MIN, { KEY_BRIGHTNESSDOWN } },
> > +       { KE_IGNORE, NOTIFY_BRNUP_MIN, { KEY_BRIGHTNESSUP } },
> 
> What's the point of keeping this code, since we don't want to send
> KEY_BRIGHTNESS* events ?

KE_IGNORE will suppress the events but also avoid printing warning
message about unknown WMI code.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux