On Sun, Mar 21, 2010 at 3:02 AM, Yong Wang <yong.y.wang@xxxxxxxxxxxxxxx> wrote:
> +static const struct key_entry eeepc_wmi_keymap[] = {
> + /* Sleep already handled via generic ACPI code */
> + { KE_KEY, 0x5d, { KEY_WLAN } },
> + { KE_KEY, 0x32, { KEY_MUTE } },
> + { KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
> + { KE_KEY, 0x30, { KEY_VOLUMEUP } },
> + { KE_IGNORE, NOTIFY_BRNDOWN_MIN, { KEY_BRIGHTNESSDOWN } },
> + { KE_IGNORE, NOTIFY_BRNUP_MIN, { KEY_BRIGHTNESSUP } },
What's the point of keeping this code, since we don't want to send
KEY_BRIGHTNESS* events ?
> + { KE_KEY, 0xcc, { KEY_SWITCHVIDEOMODE } },
> + { KE_END, 0},
> +};
Not very important, but could you re-order the keymap by code ?
> + if (code >= NOTIFY_BRNUP_MIN && code <= NOTIFY_BRNUP_MAX)
> + code = NOTIFY_BRNUP_MIN;
> + else if (code >= NOTIFY_BRNDOWN_MIN && code <= NOTIFY_BRNDOWN_MAX)
> + code = NOTIFY_BRNDOWN_MIN;
Same as above.
You may also want to add yourself to the MAINTAINERS file.
Everything else seems ok.
Thanks,
--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
