On Fri, Mar 19, 2010 at 11:30:02PM -0700, Dmitry Torokhov wrote:
>
> > +static int __init eeepc_wmi_init(void)
> > +{
> > + int err;
> > + acpi_status status;
> > +
> > + if (!wmi_has_guid(EEEPC_WMI_EVENT_GUID)) {
> > + printk(KERN_WARNING "EEEPC WMI: No known WMI GUID found\n");
> > + return -ENODEV;
> > + }
> > +
> > + err = eeepc_wmi_input_setup();
> > + if (err)
> > + return err;
> > +
> > + status = wmi_install_notify_handler(EEEPC_WMI_EVENT_GUID,
> > + eeepc_wmi_notify, NULL);
> > + if (ACPI_FAILURE(status)) {
> > + input_unregister_device(eeepc_wmi_input_dev);
>
> You need to free keymap as well. BTW, you need to do that after
> unregistering device, because otherwise there is a chance someone
> will try to modify keymap while device is still registered. I need
> to fix a couple of drivers in input too...
>
Is the input_dev still there after calling input_unregister_device? I
thought input_dev is going to be released after calling
input_unregister_device. No?
Thanks for the review.
-Yong
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
