Re: [PATCH v2] eeepc-wmi: new driver for WMI based hotkeys on Eee PC laptops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 19, 2010 at 11:30:02PM -0700, Dmitry Torokhov wrote:
> On Sat, Mar 20, 2010 at 02:03:41PM +0800, Yong Wang wrote:
> > +
> > +	status = wmi_install_notify_handler(EEEPC_WMI_EVENT_GUID,
> > +					eeepc_wmi_notify, NULL);
> > +	if (ACPI_FAILURE(status)) {
> > +		input_unregister_device(eeepc_wmi_input_dev);
> 
> You need to free keymap as well. BTW, you need to do that after
> unregistering device, because otherwise there is a chance someone
> will try to modify keymap while device is still registered. I need
> to fix a couple of drivers in input too...
> 

Hmm, this is getting unwieldy in the drivers, I think I'll take care
of in in the input core so it is possible to free sparse keymap while
input device is still registered.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux