Bug in codec L16

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for your answer! I had an old version and I didn't know it was
already fixed.



2015-08-07 11:23 GMT+02:00 Ming <ming at teluu.com>:

> Hi Alicia,
>
> You're right, of course. We've just fixed this in r5153
> (https://trac.pjsip.org/repos/changeset/5153).
> Thanks for spotting this!
>
> Regards,
> Ming
>
> On Thu, Aug 6, 2015 at 10:05 PM, Alicia Romero <alromor84 at gmail.com>
> wrote:
> > Hi List,
> > I think I have found a mistake in the L16 codec. In the function
> l16_parse()
> > the timestamp is so calculated:
> >
> > frames[count].timestamp.u64 = ts->u64 + (count * data->frame_size);
> >
> > But I think instead of using the frame size, it should use samples per
> > frame, like in the other codecs:
> >
> > frames[count].timestamp.u64 = ts->u64 + (count * samples_per_frame);
> >
> > Am I right, or am I delusional??
> >
> > Thanks!!
> >
> >
> > _______________________________________________
> > Visit our blog: http://blog.pjsip.org
> >
> > pjsip mailing list
> > pjsip at lists.pjsip.org
> > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
> >
>
> _______________________________________________
> Visit our blog: http://blog.pjsip.org
>
> pjsip mailing list
> pjsip at lists.pjsip.org
> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20150807/1b285fab/attachment.html>


[Index of Archives]     [Asterisk Users]     [Asterisk App Development]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [Linux API]
  Powered by Linux