Hi Brian,
Thanks for the report (and the patch). I fixed this in r 4781.
Regards,
Ming
On Thu, Mar 6, 2014 at 5:30 AM, Brian White <mscdex at mscdex.net> wrote:
> Hello,
>
> I noticed that doing `make install` was doing several things wrong with
> pjsua2. Here are some issues I encountered, including the diffs between the
> 2.2 release and my changes (which may not be 100% "correct"):
>
>
> 1. it wasn't installing the pjsua2 shared/static library files
>
> (./Makefile):
> 110c110,111
> < cp -af $(APP_LIB_FILES) $(DESTDIR)$(libdir)/
> ---
> > # cp -af $(APP_LIB_FILES) $(DESTDIR)$(libdir)/
> > cp -af $(APP_LIBXX_FILES) $(DESTDIR)$(libdir)/
> 120,121c121,124
> < sed -e "s!@PJ_LDLIBS@!$(PJ_LDLIBS)!" | \
> < sed -e "s!@PJ_INSTALL_CFLAGS@!$(PJ_INSTALL_CFLAGS)!" >
> $(DESTDIR)/$(libdir)/pkgconfig/libpjproject.pc
> ---
> > sed -e "s!@PJ_LDLIBS@!!" | \
> > sed -e "s!@PJ_LDXXLIBS@!$(PJ_LDXXLIBS)!" | \
> > sed -e "s!@PJ_INSTALL_CFLAGS@!!" | \
> > sed -e "s!@PJ_INSTALL_CXXFLAGS@!$(PJ_INSTALL_CXXFLAGS)!" >
> $(DESTDIR)/$(libdir)/pkgconfig/libpjproject.pc
>
> (./libpjproject.pc.in):
> < Libs: -L${libdir} @PJ_LDLIBS@
> < Cflags: -I${includedir} @PJ_INSTALL_CFLAGS@
> ---
> > Libs: -L${libdir} @PJ_LDXXLIBS@ @PJ_LDLIBS@
> > Cflags: -I${includedir} @PJ_INSTALL_CXXFLAGS@ @PJ_INSTALL_CFLAGS@
>
>
>
> 2. the symlinking for pjsua2 was wrong, causing it to instead link to a
> relative path
>
> (./pjsip/build/Makefile):
> 24c24
> < export PJSUA2_LIB_LIB=../lib/libpjsua2-$(TARGET_NAME)$(LIBEXT)
> ---
> > export PJSUA2_LIB_LIB=libpjsua2-$(TARGET_NAME)$(LIBEXT)
> 36c36
> < export PJSUA2_LIB_SONAME := ../lib/libpjsua2.$(SHLIB_SUFFIX)
> ---
> > export PJSUA2_LIB_SONAME := libpjsua2.$(SHLIB_SUFFIX)
>
>
> I was thinking there was some other change I had to make too, but I cannot
> recall it offhand. Other than the initial installation problem though,
> using the new pjsua2 API has been great so far! :-)
>
>
> - Brian
>
>
> _______________________________________________
> Visit our blog: http://blog.pjsip.org
>
> pjsip mailing list
> pjsip at lists.pjsip.org
> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20140306/87d4ddc0/attachment-0001.html>
