Right. It just doesn't seem so easy to track down ffmpeg API change points, e.g: which exact version renames CodecID to AVCodecID, which versions do and do not provide such thing like "#define CodecID AVCodecID". And as pjmedia ffmpeg_util.h is not part of public API and the function names already explicitly specify the type names, I think it is fair enough to just avoid the hassle by replacing it with "unsigned". BR, nanang On Tue, Apr 1, 2014 at 9:59 PM, Dennis Guse <dennis.guse at alumni.tu-berlin.de > wrote: > Actually I would prefer the CodecID instead of unsigned as the code is > easier readable and thus maintainable. > > > --- > Dennis Guse > > > On Tue, Apr 1, 2014 at 12:42 PM, Nanang Izzuddin <nanang at pjsip.org> wrote: > >> Hi Sa?l, >> >> We decided to just replace 'enum CodecID' with 'unsigned'. Please check >> https://trac.pjsip.org/repos/changeset/4808. >> >> Thanks for the feedbacks. >> >> BR, >> nanang >> >> >> >> On Mon, Mar 24, 2014 at 5:05 PM, Sa?l Ibarra Corretg? < >> saul at ag-projects.com> wrote: >> >>> Hi, >>> >>> Debian and Ubuntu ship with libav instead of ffmpeg and libraries are >>> called the same. Oh the joy! Making PJSIP compile on Ubuntu just took a >>> couple of small adjustments (see the attached patch). Some of the changes I >>> sent earlier for making PJSIP compile with latest FFMpeg are needed, but >>> the patch Perry merged wasn't quite what I sent. The attached patch works >>> with both libav and ffmpeg. >>> >>> >>> Cheers, >>> >>> >>> -- >>> Sa?l Ibarra Corretg? >>> AG Projects >>> >>> >>> >>> >>> _______________________________________________ >>> Visit our blog: http://blog.pjsip.org >>> >>> pjsip mailing list >>> pjsip at lists.pjsip.org >>> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >>> >>> >> >> _______________________________________________ >> Visit our blog: http://blog.pjsip.org >> >> pjsip mailing list >> pjsip at lists.pjsip.org >> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >> >> > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip at lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20140402/6947c7e2/attachment-0001.html>
