Hi! Yesterday I ran across a couple of bugs when handling incoming SUBSCRIBE requests. The first is just a typo, there is a comma missing here (http://trac.pjsip.org/repos/browser/pjproject/trunk/pjsip/src/pjsip-simple/evsub.c#L156) so the printed log line is wrong. The second one has to do with setting the UAS timeout for the initial SUBSCRIBE request. AFAIS that timer is only set here (http://trac.pjsip.org/repos/browser/pjproject/trunk/pjsip/src/pjsip-simple/evsub.c#L2069), which is only reached in case a re-SUBSCRIBE arrives, to refresh the subscription. IMHO the pjsip_evsub_accept function should set the timer after setting the response, around here (http://trac.pjsip.org/repos/browser/pjproject/trunk/pjsip/src/pjsip-simple/evsub.c#L1148), however, the set_timer function will assert on a 0 expiration time (http://trac.pjsip.org/repos/browser/pjproject/trunk/pjsip/src/pjsip-simple/evsub.c#L509) which is perfectly valid for doing "polling", so that would need to be adjusted. Hope I could help :-) Kind regards, -- Sa?l Ibarra Corretg? AG Projects
