Hi,
I think you have different problem than #1060, and frankly I can't
think of any scenario why this happened with REGISTER request. Unlike
CANCEL, the REGISTER requests would have different transaction keys
(i.e. Via branch parameter) every time they are generated (except if
CoCreateGuid behaves badly of course).
So while your patch may have helped, I'm concerned that we may hide a
bigger problem, so I'm curious to know why this happened.
?-Benny
On Mon, Nov 22, 2010 at 10:16 PM, Mark Smit <MSmit at clb.nl> wrote:
> Hi all,
>
> I have?the same?problem?described in ticket #1060. We have Windows Mobile
> device and when it looses and regains?contact with the WiFi network,
> sometimes it will not register to a SIP server.
> The ticket is set to wontfix, but I did some testing and perhaps know a
> solution.?In sip_reg.c I changed at function pjsip_regc_send I changed the
> lines
>
> ??? status = pjsip_endpt_send_request(regc->endpt, tdata, REGC_TSX_TIMEOUT,
> ????????? regc, &tsx_callback);
> ??? if (status!=PJ_SUCCESS) {
> ??????? PJ_LOG(4,(THIS_FILE, "Error sending request, status=%d", status));
> ??? }
>
> into
>
> ??? status = pjsip_endpt_send_request(regc->endpt, tdata, REGC_TSX_TIMEOUT,
> ????????? regc, &tsx_callback);
> ??? if (status!=PJ_SUCCESS) {
> ??????? PJ_LOG(4,(THIS_FILE, "Error sending request, status=%d", status));
> ??????? if (status == PJ_EEXISTS ) {
> ??????????? /* reset flag, otherwise sending can never been done */
> ??????????? regc->has_tsx = PJ_FALSE;
> ??????????? /* reset current op */
> ??????????? regc->current_op = REGC_IDLE;
> ??????? }
> ??? }
>
> That does solve my problem. With this solution the flags that block sending
> new regc transactions and the device does register normal at my SIP server.
> Is there any good reason why this should not be added to the project?
>
> regards,
> Mark
>
> _______________________________________________
> Visit our blog: http://blog.pjsip.org
>
> pjsip mailing list
> pjsip at lists.pjsip.org
> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>
>
