Hi John, Sorry for the late reply. Please see comments inline. On Wed, Oct 7, 2009 at 10:08 PM, John Ridges <jridges at masque.com> wrote: > Hi Benny, it's nice to see you back. > > Just a few quick bugs I wanted to report: > > Bug #1: PJ_SOL_TCP gives the wrong value in Windows. Or at least it does > with my VC 2005 compiler. It seems that an "enum"ed symbol is not considered > to be "#defined". Go figure. > Fixed in http://trac.pjsip.org/repos/ticket/972. Out of curiosity, which Platform SDK version do you use? I checked the SDK that comes with VS 2005 and VS 6 and they both have IPPROTO_TCP declared as macro. > Bug #2: On Windows NT, calling pj_ioqueue_accept with a value of NULL for > "local" will return an error if there is a connection immediately available > instead of connecting to it like it should. It looks like it's calling > "getsockname" with a null address pointer. > Fixed in http://trac.pjsip.org/repos/ticket/973 > Bug #3: In PJNATH, destroying the ICE transport whilst inside > "on_ice_complete" with an PJ_ICE_STRANS_OP_NEGOTIATION op causes a crash. It > seems that the on_ice_complete callback is invoked in the "on_timer" > function in ice_session.c with the ice->mutex held, and deleting the > transport deletes the mutex, so when the callback returns the function > attempts to unlock the deleted mutex (and hilarity ensues). Perhaps the > mutex should be released before calling the callback. > Fixed in http://trac.pjsip.org/repos/ticket/974 > Also, if you wouldn't mind a request, the addition of PJ_TCP_NODELAY and > PJ_SO_REUSEADDR to the socket library would be very welcome. Thanks, > Done in that ticket #'972 too. Thanks for the reports, they're all good ones! Cheers Benny > John Ridges > > > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip at lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >
