Bugfix: URL-unescape nameaddr display names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At the moment, the printing of display name doesn't escape back the
characters, so if we unescape the characters in the parsing, there is a
chance that we might end up emitting invalid message. So lets skip this for
now.

Thanks for the report though!

On Tue, Sep 22, 2009 at 8:17 PM, Michele Cicciotti <
m.cicciotti at khamsalabs.net> wrote:

>  Asterisk will escape URL-unsafe characters in nameaddr display names. The
> attached patch ensures PJSIP unescapes URL-escaped display names when it
> encounters them.
> Again, the fix is very trivial and I'm not providing a submission agreement
> unless strictly necessary.
> --
>
>   [image: KHAMSA SA]
>
> Michele Cicciotti
> Research & Development
>
> Mobile:   + 39 339 3206609
> E-mail:    m.cicciotti at khamsalabs.net
>
> KHAMSA SA
>  Via Giacometti 1 - 6900 Lugano - Switzerland
> Web:   www.khamsa.net
>
> Technical Support CH:  + 41 (0)91 2206457
> Technical Support IT:   + 39 02 911930891
> E-mail:  support at khamsa.ch
>
> Monday to Friday 10.00 - 12.00 and 14.00 - 16.00
>
>
> ..........................................................................................................................................................................................
>
> This e-mail (including attachments) is intended only for the recipient(s)
> named above. It may contain confidential or privileged
> information and should not be read, copied or otherwise used by any other
> person.
> If you are not the named recipient, please contact us immediately and
> delete the e-mail from your system.
>
> Le informazioni contenute in questo messaggio sono riservate e
> confidenziali ed ? vietata la diffusione in qualunque modo
> eseguita. Qualora Lei non fosse la persona a cui il presente messaggio ?
> destinato, La invitiamo ad eliminarlo e a non leggerlo,
> dandocene gentilmente comunicazione.
>
>
>
> Index: pjsip/src/pjsip/sip_parser.c
> ===================================================================
> @@ -1485,8 +1485,7 @@
>        /* Trim the leading and ending quote */
>        name_addr->display.ptr++;
>        name_addr->display.slen -= 2;
> -
> +       /* Unescape */
> +        name_addr->display = pj_str_unescape (pool, &name_addr->display);
>     } else if (*scanner->curptr != '<') {
>        int next;
>        pj_str_t dummy;
>
> _______________________________________________
> Visit our blog: http://blog.pjsip.org
>
> pjsip mailing list
> pjsip at lists.pjsip.org
> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>
>


-- 
Best regards,

Benny
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20091110/1ebf6e30/attachment.html>


[Index of Archives]     [Asterisk Users]     [Asterisk App Development]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [Linux API]
  Powered by Linux