Mistake in aps branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Nanang,

Don't worry, I don't use this branch for production ;-)

Samuel

Nanang Izzuddin a ?crit :
> Hi Samuel,
>
> The branch is actually for internal development only, so it is really2
> buggy (even sometime it's perhaps uncompilable :-) ). It will be
> merged to trunk once the project finished.
>
> However thanks for the report and opinion.
>
> Regards,
> nanang
>
>
> On Sun, Feb 1, 2009 at 3:57 PM, Samuel Vinson <samuelv at laposte.net> wrote:
>   
>> Hello Nanang,
>>
>> I tested aps branch, and I think there is a mistake in config.h file from
>> pjmedia-codec.
>>
>> #ifndef PJMEDIA_HAS_PASSTHROUGH_CODEC_G729
>> #   define PJMEDIA_HAS_PASSTHROUGH_CODEC_PCMA    1
>> #endif
>>
>> should be
>>
>> #ifndef PJMEDIA_HAS_PASSTHROUGH_CODEC_PCMA
>> #   define PJMEDIA_HAS_PASSTHROUGH_CODEC_PCMA    1
>> #endif
>>
>> It will be great if the pjmedia_snd_aps_modify_setting function was called
>> when the codec negotiation is finished.
>> Without this call, codec stays always the same (defined in
>> pjmedia_snd_init).
>>
>> Perhaps it needs to extend pjmedia_snd api with
>>   - modify setting
>>   - activate loud speaker
>>
>> Thanks
>>
>> Samuel
>>
>>     
>
> _______________________________________________
> Visit our blog: http://blog.pjsip.org
>
> pjsip mailing list
> pjsip at lists.pjsip.org
> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>
>
>   




[Index of Archives]     [Asterisk Users]     [Asterisk App Development]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [Linux API]
  Powered by Linux