Hi Tom, First of all, currently any bugs and fixes should be addressed via this mailing list :) Regarding first issue, we'll consider the fix, thanks! However, currently we're not really sure if ignoring unsupported chunks would be wiser than explicitly rejecting the WAV file in the first place. Second issue, could you check if it's related to (or fixed by) ticket #968 [1]? --- [1] http://trac.pjsip.org/repos/ticket/968 --- BR, nanang On Tue, Dec 1, 2009 at 1:36 AM, Tom Johnson <tomjohnson3 at gmail.com> wrote: > hi all, > > i'm not sure what i should do with these bug fixes. i tried to reach > out to benny (see below.), but didn't get an answer. > > is there a process or protocol i should follow for submitting fixes/etc.? > > thanks, tom > > ---------- Forwarded message ---------- > From: Tom Johnson <tomjohnson3@xxxxxxxxx> > Date: Wed, Nov 18, 2009 at 4:29 PM > Subject: pjmedia updates / bug fixes > To: bennylp at pjsip.org > > > hi benny, > > i've been playing around with pjsip and pjmedia and ran into a couple > of issues, which i have fixed (see source attached). i'm not sure how > to submit bug fixes / updates...so i thought i'd write you an email > with the info. (please let me know if you have a preferred method that > i should follow in the future.) > > here are the two issues, and what i did to fix them: > > 1) bug #597 (Error reading WAV files when there are extra chunks after > DATA chunk) > > i've updated wav_player.c so that it plays only the DATA chunk, and > ignores other, unrelated chunks. > > in addition to making a couple of small port struct changes, i had to > #ifdef a section of code that compares the length of the DATA chunk to > the remaining file length. (see PJMEDIA_WAV_PLAYER_VALIDATE_LENGTH.) > my thoughts: this block of code could be removed completely, since the > current DATA length check after this #ifdef-ed section validates the > length of the DATA chunk is all you really need. > > 2) endpoint creation fails when used on servers without audio subsystems. > > i added the following code in endpoint.c so that an endpoint can be > initialized if it doesn't have (or use) an audio subsystem: > > #ifdef PJMEDIA_ENDPOINT_HAS_AUDIO_SUBSYSTEM > ? ? ? ?/* Sound */ > ? ?status = pjmedia_aud_subsys_init(pf); > ? ?if (status != PJ_SUCCESS) > ? ? ? ?goto on_error; > #endif > > let me know if you have any questions. btw, i think pjsip and pjmedia > are really great! well done! > > thanks, tom > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip at lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org > >
