Hi,
In the function "acc_check_nat_addr" the call to pjsip_parse_uri fails
since the acc->contact is sent for parsing including all the headers
parameters.
I think contact parameters should be removed before parsing it.
Since I think the contact header is parsed in other places as well in
the same way it is probably not sufficient to patch only in this
function call. Either it has to be changed everywhere or the
pjsip_parse_uri function should be changed to accept the contact as
valid once the final bracket is parsed.
uri = (pjsip_sip_uri*)
pjsip_parse_uri(pool, acc->contact.ptr, acc->contact.slen, 0);
pj_assert(uri != NULL);
Is it a bug or Am I wrong?
Best regards,
javier
Javier Rodr?guez (Genaker) wrote:
> Hi Benny,
>
> You are right. Sorry for my previous post. In fact
> "+g.poc.talkburst;+g.poc.groupad" are not SIP URI parameters but Header
> parameters of the 'Contact header'. It seems that when receiving an
> incoming call the stack tries to parse the full content of the header
> parameter (i.e. <sip:PoC-ClientA at networkA.net>;
> +g.poc.talkburst;+g.poc.groupad) but should only try to parse the SIP
> URI (without header parameters) (i.e. <sip:PoC-ClientA at networkA.net>).
>
> Thanks a lot in any case.
>
> --javier
>
>
> Benny Prijono wrote:
>
>> On Mon, Sep 15, 2008 at 4:52 PM, "Javier Rodr?guez (Genaker)"
>> <javier.rodriguez at genaker.net <mailto:javier.rodriguez at genaker.net>>
>> wrote:
>>
>> Hi,
>>
>> It seems that the pjsip_parse_uri fails to parse an URI if it contains
>> 'unknown' parameters.
>> Here is an example of valid SIP URI not parsable (from
>> OMA-TS-PoC-ControlPlane-V1_0_1-20061128-A):
>> <sip:PoC-ClientA at networkA.net>; +g.poc.talkburst;+g.poc.groupad
>>
>> It seems that (pj_scan_is_eof(&scanner) ||
>> IS_NEWLINE(*scanner.curptr)) returns false.
>>
>>
>> It works fine here!
>>
>> Cheers
>> Benny
>>
>>
>>
>> Kind regards,
>> javier
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Visit our blog: http://blog.pjsip.org
>>
>> pjsip mailing list
>> pjsip at lists.pjsip.org
>> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>>
>>
>
>
> _______________________________________________
> Visit our blog: http://blog.pjsip.org
>
> pjsip mailing list
> pjsip at lists.pjsip.org
> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>
>
>
