On Mon, Jun 16, 2008 at 8:47 AM, Ondrej Sterbak <sterbo at email.cz> wrote:
> On Sun, Jun 15, 2008 at 00:04, Benny Prijono <bennylp at pjsip.org> wrote:
>> We don't have overly advanced bug reporting system, so your best bet
>> would be to post it here. :)
>
> And isn't that too much spaming for the conference? Wouldn't it be
> better to send the bug reports directly to you or Nanang?
>
Yeah I think that makes sense, I didn't think of that.
> Just 3 bugs for the illustration (first 2 as diff, third by words):
>
> Index: pjsip/include/pjsip/sip_uri.h
> ===================================================================
> --- pjsip/include/pjsip/sip_uri.h (revision 2021)
> +++ pjsip/include/pjsip/sip_uri.h (working copy)
> @@ -151,7 +151,7 @@
> * URI 'virtual' function table.
> * All types of URI in this library (such as sip:, sips:, tel:, and name-addr)
> * will have pointer to this table as their first struct member. This table
> - * provides polimorphic behaviour to the URI.
> + * provides polymorphic behaviour to the URI.
> */
> typedef struct pjsip_uri_vptr
> {
> Index: pjsip/src/pjsua-lib/pjsua_core.c
> ===================================================================
> --- pjsip/src/pjsua-lib/pjsua_core.c (revision 2021)
> +++ pjsip/src/pjsua-lib/pjsua_core.c (working copy)
> @@ -40,7 +40,7 @@
> char errmsg[PJ_ERR_MSG_SIZE];
>
> pj_strerror(status, errmsg, sizeof(errmsg));
> - PJ_LOG(3,(sender, "%s: %s [status=%d]", title, errmsg, status));
> + PJ_LOG(1,(sender, "%s: %s [status=%d]", title, errmsg, status));
> }
>
>
> And the third one:
> In pjlib/include/pj/types.h in pj_str_t is slen's type declared as
> pj_ssize_t. But in
> pjlib/include/pj/string.h pj_strlen returns pj_size_t. So one is wrong.
>
Yeah probably. Somehow I *feel* that ssize_t is more correct for slen,
but can't explain why. :)
Cheers
Benny
>
> Cheers,
> Ondrej
>
> _______________________________________________
> Visit our blog: http://blog.pjsip.org
>
> pjsip mailing list
> pjsip at lists.pjsip.org
> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>
