On Wed, Aug 6, 2008 at 12:52 PM, Pedro Gon?alves <pedro.pandre at gmail.com>wrote: > Benny Prijono wrote: > > Is the problem still with stream not being closed? > *Answer:* I think that problem's gone and I would preffer to address the > other exceptions on the other thread, as they make the application to > crash. However, I will answer your questions. > > So what do you exactly do in on_media_update()? > *Answer:* I call pjmedia_session_info_from_sdp, pjmedia_session_create, > [I now added pjmedia_conf_disconnect_port, pjmedia_conf_remove_port, > pjmedia_snd_port_disconnect and pjmedia_snd_port_destroy, so that any > existing streams are closed before creating new ones], No actually. You're still missing pjmedia_session_destroy(). And since you didn't disconnect/remove the stream from the port, that explains why the stream is not closed. And as I suggested previously, pjmedia_snd_port_destroy() is not necessary. Opening sound device is an expensive operation (few hundreds msec I think) so you don't want to do this too many times. > pjmedia_session_get_port, pjmedia_conf_get_master_port, > pjmedia_snd_port_create, pjmedia_snd_port_set_ec, > pjmedia_snd_port_connect, pjmedia_conf_add_port, > pjmedia_conf_connect_port, pjmedia_transport_attach and > pjmedia_rtp_session_init. > > > And is on_media_update() called? > *Answer:* yes, it is called after the initial offer / answer. As the Okay. I just wanted to check if there's anything wrong in the negotiation (and there isn't). So the callback is working. > > application is crashing while in the ICE connectivity checks, I don't > know if this is called after subsequent offer / answer. > > Which crash is this? The assertion that we discuss in the other thread? That has nothing to do with media, and lets not mix the discussion here since that's confusing. > And do you close the stream when the call is disconnected? A snippet > will help. > *Answer:* Yes, I do > > Sure you call pjmedia_session_destroy()? And pjmedia_transport_close() too? -benny -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20080806/e2863c65/attachment.html
