Re: A Review Request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At 3:31 PM -0400 5/18/11, Joshua Kehn wrote:
On May 18, 2011, at 3:22 PM, tedd wrote:
I am considering providing PHP code to the general public via my website

This is my first attempt:

<http://sperling.com/php/authorization/>http://sperling.com/php/authorization/

What do you people think?

-snip-

I can say I really don't like your bracing style.

I don't see a reason to use a form submit to go back to the login page, instead I normally present errors on page.

Other then that, looks good. Maybe redirect <http://sperling.com/php/>http://sperling.com/php/ to an index of examples?

Regards,

-Josh


-Josh:

There are all sorts of bracing styles, as you can see here:

http://rebel.lcc.edu/sperlt/citw229/brace-styles.php

Fortunately, we are all free to choose the one we like. :-)

I like the Whitesmiths style.

As for your other comments, they made good sense to me, so I made adjustments.

Thanks,

tedd


--
-------
http://sperling.com/

--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[Index of Archives]     [PHP Home]     [Apache Users]     [PHP on Windows]     [Kernel Newbies]     [PHP Install]     [PHP Classes]     [Pear]     [Postgresql]     [Postgresql PHP]     [PHP on Windows]     [PHP Database Programming]     [PHP SOAP]

  Powered by Linux