Hey Robero,
Thanks for the answer, the none recursion function is a good idea,
although as provided in your example if would only return one
entry from each parent it can get to and it only can get to few,
depends on how the array is sorted.
Basically you can make it work if you would sort the array from
small to high by parent value, but in my case I will get this array
pre-sorted by date, so I can't change the order.
Now, about your other suggestion, yes, it will work without the reference.
I used the reference to avoid creating "local" copies of the array.
I solved the problem by removing the reference just as you said, but then
there would be to many recursions, so I ended up with this function:
/**
* Recursion
* @array as ( id => parent )
* return array as ( id => level ) maintaining arrays' initial order
*/
function recur($array, &$sorted=array(), $pid=0, $level=0)
{
if(empty($sorted)){$return=true;}else{$return=false;}
foreach($array as $id=>$parent)
{
if($pid===$parent)
{
$sorted[$id]= $level;
unset($array[$id]);
if(in_array($id,$array)){
recur($array, &$sorted, $id, $level+1);
}
}
}
if($return){return $sorted;}
}
Checking with in_array if parent exist in array to make
less runs and saving micro seconds on return... haha.
I couldn't make it any faster, but if anybody can,
please, let me know, I would be happy to know how to.
Thanks Robero, this is first time I'm looking for help in mailing list,
and I was starting to regret writing here, but your reply changed it :)
Thanks!
David.
On Mon, Jun 30, 2008 at 6:36 AM, Roberto Costumero Moreno
<rcostu@xxxxxxxxx> wrote:
> That's not the problem. Look that the function is called with &$return, so
> there is a reference to the variable in which the function returns the value
> (if not there would not be an answer...).
>
> Otherwise, i think the problem is in the recursive call inside the function.
> Once you make the unset, you make a recursive call to the function like:
>
> recrusion(&$array, &$return, $id, $level+1);
>
> while I think the problem will be solved if you make the call just like:
>
> recrusion($array, &$return, $id, $level+1);
>
>
> Notice that the $array variable has not & symbol, so is the variable itself
> and not a reference of it.
>
> Although there is a better and simple solution for that problem (or I think
> something like this should work well):
>
>
> <?php
> function recrusion($array, $return, $pid=0, $level=0){
> foreach($array as $id=>$parent){
> if( $parent===$pid ){
> $return[$id]= $level;
> unset($array[$id]); /* remove this to get correct results */
>
> $level++;
> $pid = $id;
> }
> }
> }
> $return= array();
> $array= array(1=>0,2=>1,3=>2,4=>3,5=>2,6=>2,7=>6,8=>6,9=>0,10=>0);
> recrusion($array, &$return);
>
> var_dump( $return );
> ?>
>
> So you don't make any recursive call, you don't lose too much efficiency and
> it should work well for the whole array.
>
> Try the two solutions above and see whether if any is up to your problem.
>
>
> Cheers,
>
> Roberto
>
>
> On Mon, Jun 30, 2008 at 14:27, Jason Norwood-Young
> <jason@xxxxxxxxxxxxxxxxxxx> wrote:
>>
>> On Sun, 2008-06-29 at 18:25 -0800, David Sky wrote:
>> > Hello everyone!
>> >
>> > A couple of days ago I submitted a bug to PHP
>> > http://bugs.php.net/bug.php?id=45385
>> > But I was mistaken, apparently it's not a bug.
>> > And I was "sent" here to get help.
>>
>> I think you might be forgetting to return $return.
>>
>> J
>>
>>
>> --
>> PHP General Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>
>
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
