Nathan Rixham wrote:
<?$_productCollection=$this->getLoadedProductCollection()?> <?if(!$_productCollection->getSize()):?> <div class="note-msg"> <?=$this->__('There are no products matching the selection.')?> </div>first 5 lines I've seen of it and it's got short-tags, escapes in and out of php/html, no templating engine and no language file, or even concideration of future implementation.and is all that inside a class? I see a $this but no "class classname {" just some constuctive critism, could be good though!
Yeah, I gotta agree here, most of the systems I have worked on have disabled the short-open tags and other things to secure the site, so definitely something to keep in mind. This page alone would break as would <?= tags if they live anywhere (shortcut for "<?php echo ").
Wolf -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
