Than I have quite few notes about that function:
- affix is not checked on entry, and should be unsigned,
Could be Assert( affix>=0 && affix < Conf->nAffixData )
- for sake of safety uint32_t should be used instead of unsigned int,
in the cast
see patch
- there should be some safety limit for lenght of str,
It's a C-string
--
Teodor Sigaev E-mail: teodor@xxxxxxxxx
WWW: http://www.sigaev.ru/
--
Sent via pgsql-general mailing list (pgsql-general@xxxxxxxxxxxxxx)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general
