On Sun, May 11, 2008 at 11:48:29PM -0400, Tom Lane wrote:
> "Scott Marlowe" <scott.marlowe@xxxxxxxxx> writes:
> > Is it reasonable behavior to have \timing along toggle and \timing on
> > / \timing off be a forced switch? Just thinking of other scripts
> > where this isn't a problem and having to update them.
>
> The command without an argument should certainly keep the old toggle
> behavior, for backwards compatibility.
Attached patch does some of the right thing, but doesn't yet handle
error cases. How liberal should we be about capitalization, spelling,
etc.?
Cheers,
David.
--
David Fetter <david@xxxxxxxxxx> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@xxxxxxxxx
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
Index: src/bin/psql/command.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/bin/psql/command.c,v
retrieving revision 1.188
diff -r1.188 command.c
887c887,897
< pset.timing = !pset.timing;
---
> char *opt = psql_scan_slash_option(scan_state,
> OT_NORMAL, NULL, true);
> if (opt)
> {
> if (strcmp(opt, "on") == 0)
> pset.timing = true;
> else if (strcmp(opt, "off") == 0)
> pset.timing = false;
> }
> else
> pset.timing = !pset.timing;
