Alvaro Herrera <alvherre@xxxxxxxxxxxxxx> writes: > I think if we want to improve how this code is seen by the compiler by > modifying it, we should just remove the NULL/NIL assignments. It's a > pretty arbitrary (and rather small) subset of fields being initialized, > fields which very obviously have been zeroed by memset already, so I > don't see any value in the explicit assignments. I have to concede that it's unclear why we're filling just these fields explicitly and not any others. We're at least consistent: all the callers of select_rtable_names do it the same way. regards, tom lane
