On Sun, Apr 12, 2020 at 4:23 PM Tom Lane <tgl@xxxxxxxxxxxxx> wrote:
Magnus Hagander <magnus@xxxxxxxxxxxx> writes:
> And FWIW, I do think we should change the default. And maybe spend some
> extra effort on the message coming out of pg_upgrade in this case to make
> it clear to people what their options are and exactly what to do.
Is there any hard evidence of checksums catching problems at all?
Let alone in sufficient number to make them be on-by-default?
I would say yes. I've certainly had a fair number of cases where they've detected storage corruption, especially with larger SAN type installation. And coupled with validating the checksum on backup (either with pg_basebackup or pgbackrest) it enables you to find the errors *early*, while you can still restore a previous backup and replay WAL to get to a point where you don't have to lose any data.
I believe both Stephen and David have some good stories they've heard from people catching such issues with backrest as well.
This and as Michael also points out, it lets you know that the problem occurred outside of PostgreSQL, makes for very important information when tracking down issues.
