Hi, On 2018-07-20 08:27:34 -0400, Robert Haas wrote: > On Thu, Jul 19, 2018 at 4:32 PM, Andres Freund <andres@xxxxxxxxxxx> wrote: > >> 1. Why the error message changes? If there's a good reason, it should > >> be done as a separate commit, or at least well-documented in the > >> commit message. > > > > Because there's a lot of "invalid input syntax for type %s: \"%s\"", > > error messages, and we shouldn't force translators to have separate > > version that inlines the first %s. But you're right, it'd be worthwhile > > to point that out in the commit message. > > It just seems weird that they're bundled together in one commit like this. I'll push it separately. > Nothing else from me... Thanks for looking! Greetings, Andres Freund
