Re: [PATCH] together: Fix the description of state traversal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 30, 2023 at 11:19:51PM +0800, Alan Huang wrote:
> 
> > 2023年5月30日 08:40,Paul E. McKenney <paulmck@xxxxxxxxxx> 写道:
> > 
> > On Sun, May 28, 2023 at 04:40:20PM +0000, Alan Huang wrote:
> >> There seem to be some issues with the description of state transitions.
> >> This patch fixes that.
> >> 
> >> Signed-off-by: Alan Huang <mmpgouride@xxxxxxxxx>
> >> ---
> >> together/applyrcu.tex | 7 ++++---
> >> 1 file changed, 4 insertions(+), 3 deletions(-)
> >> 
> >> diff --git a/together/applyrcu.tex b/together/applyrcu.tex
> >> index 09a265f7..dee027b9 100644
> >> --- a/together/applyrcu.tex
> >> +++ b/together/applyrcu.tex
> >> @@ -676,11 +676,12 @@ The normal path through this state machine traverses the states CLOSED,
> >> OPEN, CLOSING (with an invocation of \co{call_rcu()}), and back to CLOSED
> >> once the callback has been invoked.
> >> If \co{open()} is invoked before the grace period completes, the
> >> -state machine traverses the cycle OPEN, CLOSING (with an invocation
> >> -of \co{call_rcu()}), and back to CLOSED once the callback has been invoked.
> >> +state machine traverses the cycle OPEN, CLOSING (with
> >> +an invocation of \co{call_rcu()}), REOPENING, and back to OPEN once the
> >> +callback has been invoked.
> >> If \co{open()} and then \co{close()} are invoked before the grace period
> >> completes, the state machine traverses the cycle OPEN, CLOSING (with
> >> -an invocation of \co{call_rcu()}), REOPENING, and back to OPEN once the
> >> +an invocation of \co{call_rcu()}), REOPENING, RECLOSING, and back to CLOSING once the
> >> callback has been invoked.
> > 
> > I took this patch (thank you!), but wonder if we should describe the
> > additional callback and additional transition to CLOSED, both here
> > and below.  Thoughts?
> 
> That would be more accurate. But the transition to CLOSED has already been
> described at the beginning of this paragraph. And omitting this description can
> encourage readers to engage in critical thinking and draw their own conclusions.
> 
> But others may prefer more accurate explanations :)
> 
> So, both descriptions work for me.

Fair enough, let's keep it as your patch has it for now.  ;-)

							Thanx, Paul

> Thanks,
> Alan
> 
> > 
> > Thanx, Paul
> > 
> >> Given an indefinite alternating sequence of \co{close()} and \co{open()}
> >> -- 
> >> 2.34.1
> >> 
> 



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux