Re: [PATCH -perfbook 1/4] CodeSample/formal/rcutorture.sh: Ignore Makefile and Kconfig*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 04, 2023 at 08:41:03AM +0900, Akira Yokosawa wrote:
> kernel/rcu/Makefile was new to Linux v3.13 when RCU related code were
> moved under kernel/rcu/.
> kernel/rcu/Kconfig was new to Linux v4.13.
> 
> Up until v3.12, RCU-related lines in Makefile and Kconfig were not
> counted.  So, the extra counts result in a small disjoint of bar height,
> especially between v4.11 and v4.13.
> (v4.12 was an outlier due to code duplication of old and new SRCU.)
> 
> Exclude those files from RCU LOC to be fair.
> 
> Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx>

Looks good, queued and pushed, thank you!

							Thanx, Paul

> ---
>  CodeSamples/formal/rcutorture.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CodeSamples/formal/rcutorture.sh b/CodeSamples/formal/rcutorture.sh
> index bc9a2855b623..236868054e47 100644
> --- a/CodeSamples/formal/rcutorture.sh
> +++ b/CodeSamples/formal/rcutorture.sh
> @@ -25,7 +25,7 @@ tags="`git tag -l | grep '^v' | grep -v -e - | grep -v '\..*\..*\.' | grep -v '2
>  for t in $tags
>  do
>  	git reset --hard $t > /dev/null 2>&1
> -	nontorture="`ls kernel/*rcu*.* kernel/rcu/* include/linux/*rcu* 2> /dev/null | grep -v torture | grep -v rcuperf | grep -v refperf | grep -v rcuscale | grep -v refscale`"
> +	nontorture="`ls kernel/*rcu*.* kernel/rcu/* include/linux/*rcu* 2> /dev/null | grep -v torture | grep -v rcuperf | grep -v refperf | grep -v rcuscale | grep -v refscale | grep -v Makefile | grep -v Kconfig`"
>  	ntn="`wc -l $nontorture 2> /dev/null | tail -1 | awk '{ print $1 }'`"
>  	tn="`wc -l tools/testing/selftests/rcutorture/configs/*/*.sh kernel/rcutorture.c kernel/rcu/torture.c kernel/rcu/rcutorture.c kernel/rcu/rcuperf.c kernel/rcu/refperf.c kernel/rcu/rcuscale.c kernel/rcu/refscale.c kernel/torture.c tools/testing/selftests/rcutorture/bin/* 2> /dev/null | tail -1 | awk '{ print $1 }'`"
>  	frac="`awk -v ntn=$ntn -v tn=$tn 'END { printf "%.1f", 100 * tn / (tn + ntn) "%"; }' < /dev/null`"
> 
> base-commit: f8354eceed493a403160202591c6c383387c4ddc
> -- 
> 2.25.1
> 



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux