Re: [PATCH 2/3 -perfbook] together/refcnt: Adjust tense with 'have released'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 21, 2021 at 12:23:13AM +0900, Akira Yokosawa wrote:
> Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx>
> ---
> Paul,
> 
> This is in your recent update.
> The former part of "or" says "both CPUs have released ...", so the
> latter part should say "(both CPUs have) exited ...", I suppose.
> 
> "or have exited" might be the right fix, but it sounds redundant
> to me.  Up to you!

In this case, what you have works fine.  The reason that it works is
because there is only the four words "released their hazard pointers"
between "both CPUs have" and "exited their...".  If there was instead
a long run of text instead of just four words, repeating the "both CPUs
have" would be a good way of helping the reader to make the connection
across that long run of text.

I took all three patches, all good catches!  My eyes apparently are not
as young as they once were, so thank you very much!!!

							Thanx, Paul

>         Thanks, Akira
> --
>  together/refcnt.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/together/refcnt.tex b/together/refcnt.tex
> index 829af167..599ae5f0 100644
> --- a/together/refcnt.tex
> +++ b/together/refcnt.tex
> @@ -257,7 +257,7 @@ and any needed memory barriers or disabling of compiler optimizations
>  will be provided by the hazard-pointers or RCU infrastructure.
>  Therefore, if two CPUs release the final two references concurrently, the
>  actual cleanup will be deferred until both CPUs have released their hazard
> -pointers or exits their RCU read-side critical sections, respectively.
> +pointers or exited their RCU read-side critical sections, respectively.
>  
>  \QuickQuiz{
>  	Why isn't it necessary to guard against cases where one CPU
> -- 
> 2.17.1
> 
> 



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux