Hello Elad,
On Fri, 26 Apr 2019 07:23:20 -0400, Elad Lahav wrote:
> The following issues may not be deemed important enough to fix, but
> I'll point them out nevertheless:
>
[...]
> - Listing 4.2 could have just used waitpid() instead of the loop.
Listing 4.2 shows our implementation of waitall() function used under
CodeSamples/ directory of perfbook's repository.
Your feedback prompted me to review the listing and I noticed that
the name of the function is missing there.
I fixed the position of extraction markers in api-pthreads.h
Please find the patch below.
> If I were really a nit-picking person I would have pointed out the
> various places in chapters 2 and 3 where infinitives are being split,
> but I'm not so I won't ;-).
As far as I am concerned, I like the colloquial tone of perfbook
and have no trouble seeing split infinitives as long as they are easy
to understand. Just a non-native speaker's opinion.
Thanks, Akira
> --Elad
>
----------8<------------------
>From fec0187d2cb12fdf13a8c040c447c37c1bd5e183 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <akiyks@xxxxxxxxx>
Date: Sun, 28 Apr 2019 00:41:02 +0900
Subject: [PATCH] toolsoftrade: Fix extraction range of waitall()
Commit 29d0c7c185f2 ("toolsoftrade: Add labels in code samples as
comments") failed to include the function name and the closing brace
in the snippet of waitall() extracted from api-pthreads.h.
The original snippet removed in commit a62cf8469280 ("toolsoftrade:
Reference line in code snippets by label") contained those
lines.
Restore them by repositioning meta commands in api-pthreads.h
Reported-by: Elad Lahav <e2lahav@xxxxxxxxx>
Fixes: 29d0c7c185f2 ("toolsoftrade: Add labels in code samples as comments")
Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx>
---
CodeSamples/api-pthreads/api-pthreads.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/CodeSamples/api-pthreads/api-pthreads.h b/CodeSamples/api-pthreads/api-pthreads.h
index f5510f01..5d17a9bd 100644
--- a/CodeSamples/api-pthreads/api-pthreads.h
+++ b/CodeSamples/api-pthreads/api-pthreads.h
@@ -287,9 +287,9 @@ static __inline__ void wait_all_threads(void)
/*
* Wait on all child processes.
*/
+// \begin{snippet}[labelbase=ln:api-pthreads:api-pthreads:waitall,commandchars=\%\[\]]
static __inline__ void waitall(void)
{
-// \begin{snippet}[labelbase=ln:api-pthreads:api-pthreads:waitall,commandchars=\%\[\]]
int pid;
int status;
@@ -303,8 +303,8 @@ static __inline__ void waitall(void)
}
poll(NULL, 0, 1); //\fcvexclude
} //\lnlbl{loopb}
-// \end{snippet}
}
+// \end{snippet}
static __inline__ void run_on(int cpu)
{
--
2.17.1
