Re: [PATCH 2/2] count: Adjust type of variable 'counter' with code snippet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018/10/03 00:16:12 +0900, Akira Yokosawa wrote:
> From a9c276c3da87ed327d003a70d60777f41999b4fc Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@xxxxxxxxx>
> Date: Wed, 3 Oct 2018 00:08:49 +0900
> Subject: [PATCH 2/2] count: Adjust type of variable 'counter' with code snippet
> 
> In the actual code of count_stat.c, the per-thread variable
> "counter" has the type "unsigned long".
> 

And the other description on Listing 5.3 in the text needs some reworking
to reflect the changes in the snippet. Paul, can you have a look into
this?

        Thanks, Akira

> Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx>
> ---
>  count/count.tex | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/count/count.tex b/count/count.tex
> index 4f760a4..9f9fd0f 100644
> --- a/count/count.tex
> +++ b/count/count.tex
> @@ -487,7 +487,7 @@ Listing~\ref{lst:count:Array-Based Per-Thread Statistical Counters}
>  (\path{count_stat.c}).
>  \begin{lineref}[ln:count:count_stat:inc-read]
>  Line~\lnref{define} defines an array containing a set of per-thread counters of
> -type \co{long} named, creatively enough, \co{counter}.
> +type \co{unsigned long} named, creatively enough, \co{counter}.
>  
>  Lines~\lnref{inc:b}-\lnref{inc:e}
>  show a function that increments the counters, using the
> @@ -501,7 +501,7 @@ show a function that reads out the aggregate value of the counter,
>  using the \co{for_each_thread()} primitive to iterate over the list of
>  currently running threads, and using the \co{per_thread()} primitive
>  to fetch the specified thread's counter.
> -Because the hardware can fetch and store a properly aligned \co{long}
> +Because the hardware can fetch and store a properly aligned \co{unsigned long}
>  atomically, and because \GCC\ is kind enough to make use of this capability,
>  normal loads suffice, and no special atomic instructions are required.
>  \end{lineref}
> 




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux