2017/05/30 9:02、Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx> のメッセージ: > On Tue, May 30, 2017 at 07:13:23AM +0900, Akira Yokosawa wrote: >>> From fd5fb9afb6b99b15370a9823b42fa2a92342b92a Mon Sep 17 00:00:00 2001 >> From: Akira Yokosawa <akiyks@xxxxxxxxx> >> Date: Tue, 30 May 2017 06:52:40 +0900 >> Subject: [RFC PATCH 0/4] CodeSamples: Cleanups and fixes >> >> Hi Paul, >> >> While I was looking around CodeSamples, I encountered several >> warnings in build and an infinite loop in one of sample codes. >> Also, I found that CodeSamples/api.h and CodeSamples/Makefile.arch >> can be removed from repository if their recipe are properly >> written in Makefiles. >> >> Patch 1 adds rules to generate Makefile.arch and api.h that >> suit the architecture of you host. As I don't have ppc64 or >> arm host environment, I tested it only on x86_32 and x86_64. >> I'd like to know if it works on ppc64 and arm. >> >> Patch 2 removes the redundant files. > > I took the first two, and it is nice to just be able to type "make" > in the CodeSamples directory! ;-) Does this work on ppc64 and arm (whatever arm platform you have access to)? > >> Patch 3 and 4 are fixes of warnings and infinite loops. > > I have some concerns here, and will reply to the patches. > I see your points. I'll respin. Thanks, Akira (from mobile, might be QP encoded) > Thanx, Paul > >> Thoughts? >> >> Thanks, Akira >> -- >> Akira Yokosawa (4): >> CodeSamples: Add rule to generate Makefile.arch and api.h >> CodeSamples: Remove generated files from repository >> CodeSamples: Use 'intptr_t' to be compatible with 'void *' >> CodeSamples/defer: Add compiler barriers in gettimestampmp.c >> >> CodeSamples/.gitignore | 4 +- >> CodeSamples/Makefile | 18 + >> CodeSamples/Makefile.arch | 6 - >> CodeSamples/SMPdesign/Makefile | 3 + >> CodeSamples/SMPdesign/matmul.c | 13 +- >> CodeSamples/SMPdesign/smpalloc.c | 11 +- >> CodeSamples/advsync/Makefile | 3 + >> CodeSamples/api.h | 808 ------------------------- >> CodeSamples/count/Makefile | 3 + >> CodeSamples/datastruct/Issaquah/Makefile | 3 + >> CodeSamples/datastruct/Issaquah/existence_test | Bin 26359 -> 0 bytes >> CodeSamples/datastruct/hash/Makefile | 3 + >> CodeSamples/datastruct/log/Makefile | 3 + >> CodeSamples/datastruct/skiplist/Makefile | 3 + >> CodeSamples/defer/Makefile | 3 + >> CodeSamples/defer/gettimestampmp.c | 5 +- >> CodeSamples/depends.mk | 43 ++ >> CodeSamples/intro/Makefile | 3 + >> CodeSamples/intro/threadcreate.c | 7 +- >> CodeSamples/locking/Makefile | 3 + >> CodeSamples/toolsoftrade/Makefile | 3 + >> 21 files changed, 117 insertions(+), 831 deletions(-) >> delete mode 100644 CodeSamples/Makefile.arch >> delete mode 100644 CodeSamples/api.h >> delete mode 100755 CodeSamples/datastruct/Issaquah/existence_test >> create mode 100644 CodeSamples/depends.mk >> >> -- >> 2.7.4 >> > -- To unsubscribe from this list: send the line "unsubscribe perfbook" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
