Re: [PATCH] Include fix

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

 



Am 27.01.22 um 23:24 schrieb Darren Tucker:
> For this specific diff: in most cases we put the required includes in the .c file. Is there some case where your change is needed to compile?

Yes, of course. It is the auth.h header itself that uses a typedef (HostStatus) from hostfile.h, so including just auth.h without prior inclusion of hostfile.h leads to a compilation error. That's what the patch comment tries to express...

I came across this (and the problem addressed by the other patch I submitted today, which is very similar) writing an extension to sshd (which I plan to propose when it's ready). This extension adds some new .c files, and there the two problems surfaced.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev



[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux